421
edits
Changes
Jump to navigation
Jump to search
mLine 23:
Line 23: + + + + + + + + + + + + + + + + + + + + + + + + + + + +
update to project - LENGTHY
Thanks!! [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 19:59, 9 November 2022 (UTC)
Thanks!! [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 19:59, 9 November 2022 (UTC)
:My main question is: When you say Standard Portrait, what are you referring to? Wouldn't the Neutral portrait always be their "standard"? I notice on Abigail, the Abigail Neutral.png is actually her $6, where Neutral is $0 (Abigail.png). Caroline Neutral.png is actually Caroline Unique $3 (her unique is her angry). That being said... I've tested Loved, Liked, Neutral, Dislike, and Hated gifts on all giftable NPCs and referencing '''Game\Portraits''' and have a clear idea of what's happening and can make progress tomorrow. I have notes so I can get to work on this tomorrow pending your go-ahead. '''There's a lot so bear with me...'''
::Many Category:NPC_images are inconsistent. Many have a (NPC) Neutral.png which is $3, $6, etc. Some have labels of (NPC) Neutral.png and some are just (NPC).png. There are numerous inconsistencies regarding Romanceable and Non-romanceable characters in regard to the $3+ naming conventions, as characters like Demetrius Annoyed.png would be a romanceable character’s $4/$L. My recommendations, should you allow me:
:::Come up with a standardized naming convention
:::* Either label all “Standard” images as "Neutral" or remove "Neutral" from all “Standard” images. These two should be one and the same. I would personally include Neutral for all.
:::*Label '''ALL''' images with it’s respective '''$#''' symbol so '''people looking at Category:NPC_images in the future can discern''' which image in '''Game\Portraits''' is the one being referenced. Thinking something like ''Abigail Neutral $0.png'', ''Abigail Neutral $k.png'', or swap the "$" for an "S" if the wiki doesn’t like it. Perhaps even ''$0 Abigal Neutral.png'' to keep images in order since the wiki auto-alphabetizes.
:::*Since "$0", "$1", and "$2" are '''ALWAYS''' consistently Neutral, Happy, and Sad, label the images as such and remove the ''Concerned'' tag for "$2". Similarly, for '''romanceable''' characters we should continue the normal naming convention of "Unique" for "$3", "Love" for "$4" (''removing blush''), and "Anger" for "$5" (''removing annoyed''). This would be in line with the code found at Lines 13:23 of Game::Dialogue.cs. Exception to this could be "Unique/$3/$u".
:::*For '''non-romanceable characters''', continue the "$0", "$1", and "$2" naming convention and label everything else as best suited by the image. For example, Kent’s "Angry" is in the "Unique/$3/$u" slot, but it makes much more sense for it to be "Angry". Some characters have an "Annoyed" ''and'' "Angry", and some characters like Dwarf and Wizard only have 1 or 2 images.
:::*We should include all images from the file at Game\Portraits even if they are duplicates and they should follow the naming convention above.
::My gift testing concluded (Dwarf always uses Neutral/$0/$k):
:::*Love always uses Happy/$1/$h except - Evelyn uses Neutral OR $3 (same image)
:::*Like always uses Happy/$1/$h.
:::*Neutral always uses Neutral. Some weird pieces occur:
::::*Maru’s $0 and $7 are the same
::::*Penny’s $0, $5, and $8 are the same
::::*Sandy’s $0 and $3 are the same
::::*Elliot’s $0, $3, and $6 are the same
::::*Harvey’s $0, $6, and $10 are the same
::::*Sebastian’s $0, $3, and $6 are the same
:::*Dislike always uses Concerned/Sad/$2/$s
:::*Hate always uses Concerned/Sad/$2/$s except - Pam uses Unique/$3/$u (in wiki as Anger)
:With your approval, I can start work on this tomorrow, or respond to a specific bullet point and we can brainstorm. I would comb through the page of each NPC to verify the "Standard", Gifts, and Portraits (which I would not include duplicates from ''Game\Portraits''') are all displaying correctly (and in order). I have familiarized myself with the image upload and re-upload process as well. I have sourced information from game testing, '''Game\Portraits''', and '''Game::Dialogue.cs''', and received some insight via the SDV Discord regarding "hardcoding" which utilizes the image labelled '''Portraits.png''' below and loads the correct Portrait from '''Game\Portraits'''. I have a 4-page word doc of notes and things to fix in '''Category:NPC_images''' first, then once this is corrected, I can correctly label NPC Gifts without having to go back to each '''Category:NPC_images''' page to verify I'm grabbing the right file. Would be much easier to look at my Excel sheet and say "oh, x's Like is (NPC) Happy.png" rather than hunting down which one is correct. [[User:Spiderkace|Spiderkace]] ([[User talk:Spiderkace|talk]]) 05:32, 10 November 2022 (UTC)
[[File:Portraits.png|thumb|left]]