Talk:Walleye

This talk page is for discussing Walleye.
Sign and date your posts by typing four tildes (~~~~). Put new text below old text.	Be polite. Assume good faith. Don't delete discussions.

Location

The Walleye is a fish that can be caught in the river (in Pelican Town or Cindersap Forest), the Mountain Lake, and the Cindersap Forest pond during Fall when it is raining. It can also be caught in Winter if a Rain Totem is used. It can randomly be found in Garbage Cans during Fall and Winter, or at the Traveling Cart for data-sort-value="105"315–1,000g. "If the player chooses the Riverland Farm or the Forest Farm, Walleye can also be caught in the farm pond."

Game code indicates it's available in Riverlands, Hill-Top, Forest, Wilderness, and Four Corners Farms, and I see nothing indicating the Walleye is restricted to the Forest Farm Pond and not the River as well. Also the Bundles page doesn't include the Mountain Lake as a catchable location. I'm not going to make changes without verifying with someone here as I've gotten some slight pushback on cleaning things up and consistency. Also think it would be nice if the Bundles themselves were Heading 3 or 4 or whatever so they could be accessible through the TOC, but that's just my opinion. (talk) 00:06, 9 November 2022 (UTC)

There is no river on the Forest Farm, so I'm not sure what you mean there. When you say "game code" you need to specify which function and class you're referring to. And as I said on my talk page, the game code can be tricky. You need to step through the code and/or test extensively in-game before making multiple changes to the wiki, especially when you're adjusting your own changes. Alright?

In Farm::getFish, the location is set to 0 for the Hill-Top farm (which normally means river), 1 for Riverland, Forest, & 4-Corners farms (which normally means pond), and -1 (anywhere) for all other farms. However, we need to test in-game and step through the code to be sure that those are accurate. This is a time-consuming process! So, when I say "proceed with caution", I mean it.

Having said that, there are inconsistencies across pages on the wiki, and I appreciate your desire and efforts to rectify those. The Bundles page says the Walleye can be found in "Lakes" -- this should say "the Mountain Lake", as it's the only lake in the game (the "lake" in Cindersap Forest is a pond, not a lake). That's an easy problem to fix. As for the rest, we need more testing before making changes. margotbean (talk) 03:52, 9 November 2022 (UTC)

Typo, meant Cindersap Forest when referring to the Pond/River. I didn't specify it here but I've specified it in multiple locations. I'm cross referencing Data\Locations, Data\Fish, and Farm::getFish. Hill-Top Farm setting 0 is referring to Data\Locations which specifies a 0 for River in Cindersap Forest, which Hill-Top pulls its pool from (https://stardewvalleywiki.com/Modding:Fish_data#Spawn_locations)and etc etc I'm saying the same thign you've said the same, but I guess I shoot back to "if we can't trust the code, what can we trust". In the meantime, I posit a question: Should we leave misleading or incorrect information if the code says otherwise when compared to the wiki, without testing? Or should we make an edit with code-"correct" information with/without a reference or note? I just want to make sure I'm marking the correct locations to come back to, or if I need to "ignore" it until there's proof. Spiderkace (talk) 04:08, 9 November 2022 (UTC)

We both want the same thing: an accurate wiki. My only issue is that you've made multiple changes, and then went back and edited them to remove the 4-Corners farm, in the same day. So, slow down!

And, no, you can't always trust the code unless you step through it. However, in this case, I think creating a farm and doing some fishing would enough to verify the changes you want to make that are based on the static code from ILSpy. So, mark the spots where you see things that look wrong, make sure you're reasonably correct about your changes (by doing some fishing on a non-standard farm map), and then make the changes. If you wait for proof from someone else, you'll be waiting a long time, as my "to do" list stretches back to v1.3 in some cases. ok? Good? Thank you, margotbean (talk) 04:23, 9 November 2022 (UTC)

I can agree there. Clearly I'm new to wiki editing and got a little... ambitious. You want info vetted, and I understand it. Do you have that list publicly where I could possibly look into/test some things for you? If I can assist there or at least take more time off of you double checking other's work, I'm sure the wiki would benefit. Spiderkace (talk) 15:41, 9 November 2022 (UTC)

I'm very glad we're on the same page! Perhaps you could add info about non-standard farms to pages for fish that aren't used in Bundles? We agree at this point that your existing edits are good info, so there's no reason not to. Thank you very much! I'm glad I didn't squash your enthusiasm entirely... 😁

I'll move over to your talk page with the details about another project. margotbean (talk) 19:23, 9 November 2022 (UTC)