|This talk page is for discussing Burglar's Ring.|
Was surprised to see no proof from the code that the ring's effect doesn't stack, so I pulled the relevant section from GameLocation.cs. The function is "monsterDrop" starting at line ~2427, but I'll simplify it here.
monsterDrop() load monster loot table find tile to center item drops on set base number of drops if (player is wearing Burglar's Ring) get monster name if (valid monster) increase total number of drops randomly pick tiles to drop each item on drop monster loot if (player is wearing Burglar's Ring) drop monster loot //identical to above if (player has magnifying glass AND passes random number check) drop secret note
The game checks that the player is wearing the ring, but it's a binary sort of deal. Either you're wearing the ring or you're not. Wearing multiple rings doesn't give additional checks, so the effect does not stack.
2x Drops or 2x Chance?
Wiki says "Monsters have 2× the chance of dropping a loot item". I don't think that's a good way to state how it works. I don't have the code snippet, but it appears to roll the chance to drop the item twice. That's not the same thing. Can someone check the code and update it? --Unsigned comment by Raist (talk) 14:10, 19 July 2020
- I agree there is ambiguity in "chance". This could mean opportunities, or odds. For completeness, I will list all the places that add items to a monsters loot pool.
- The Monster resource file. This contains the bulk of items that can be dropped. These are initially populated when the monster is generated. A burglar's ring causes a second roll of all items in here, at the time the monster is killed.
- Monster::getExtraDropItems. These add additional items at the time of death. A burglar's ring causes a second call to this method at the time the monster is killed.
- Monster constructors. Some monsters have items added directly in the constructor. This includes the chance for diamonds and prismatic shards once you have reached the bottom. Other examples are slime eggs from all slimes, and iridium ore from purple slimes. There is also Algae soup from mutant grubs, and a number of wilderness golem drops. A burglar's ring has no effect on these drops i.e. a burglar's ring does not give an additional opportunity to drop a slime egg.
- This page does need a bit of rewording. BlaDe (talk) 21:31, 23 July 2020 (UTC)