Template talk:Quality

From Stardew Valley Wiki
Jump to navigation Jump to search
This talk page is for discussing Template:Quality.
  • Sign and date your posts by typing four tildes (~~~~).
  • Put new text below old text.
  • Be polite.
  • Assume good faith.
  • Don't delete discussions.

Image link suggestion for non-English use

Just something I noticed: On non-English pages using this template will result in dead links for any image. It's easy to miss when editing due to the link coming from an image there will be no red text. Since it doesn't do this on English this will be a common trap when translating pages, because the |link= parameter wasn't originally needed/used. Example:

English German (& others)
Apple.png
Gold Quality Icon.png
Apple
Apple.png
Gold Quality Icon.png
DE:Apfel
easy to use and correct links image links to English name / dead link

If every editor pays attention to this behavior, it can be caught&corrected every time but for future-proofing and ease of use I would suggest either changing the non-English versions of this template to add link= or use the translated link such as how Template:Name Apple.png Apple functions. Dubesor (talk) 00:36, 9 May 2021 (UTC)

This template wasn't designed to display text, just the image and a quality star. Translation shouldn't be necessary. The image itself shouldn't link to anything, but if it did, it would link to the File page for either the apple or the quality star, which exist in all languages. I'm not sure I understand the problem. margotbean (talk) 00:44, 9 May 2021 (UTC)
Never mind, I see the problem. The template is already set up to handle the link and alt parameters, so translators just need to use them. As for this template being embedded in infobox templates, that's a pretty large can of worms. margotbean (talk) 00:51, 9 May 2021 (UTC)
I have removed the link and alt parameters from this template, and updated the documentation for all affected templates. Technically the parameters still exist in other templates, but they will be ignored. Someday I hope to clean up the damage caused by the massive template rewrite that happened shortly before the wiki changed ownership, but for now, this problem should be patched. Please let me know if you see any problems or oddities with this change. Thanks, margotbean (talk) 18:13, 9 May 2021 (UTC)
Yes, this fixed the wrong/dead link issue on non-english pages, thanks! Dubesor (talk) 02:15, 10 May 2021 (UTC)