Changes

Jump to navigation Jump to search
Line 27: Line 27:  
Apart from [https://stardewcommunitywiki.com/Talk:Speed-Gro Speed-Gro Mechanics], there's another bug in ConcernedApe's codes. When he calculated the days to be removed, he didn't consider the situation where days of the stage is less than 0 day.
 
Apart from [https://stardewcommunitywiki.com/Talk:Speed-Gro Speed-Gro Mechanics], there's another bug in ConcernedApe's codes. When he calculated the days to be removed, he didn't consider the situation where days of the stage is less than 0 day.
   −
Let's take grape as an example. The stage of grape is <code>{1, 1, 2, 3 ,3}</code> in the <tt>crops.xnb</tt>. When we have Hyper Speed-Gro and Agriculturist at the same time, the speed increase should be 0.43. 0.43 * (1+1+2+3+3) = 4.3 ≈ 5. Therefore, 5 days should be removed from the grapes' growth stage. It should take 5 days to grow and can be harvested on the 6th day. The following is the normal process:
+
Let's take grape as an example. The stage of grape is <code>{1, 1, 2, 3 ,3}</code> in the <samp>crops.xnb</samp>. When we have Hyper Speed-Gro and Agriculturist at the same time, the speed increase should be 0.43. 0.43 * (1+1+2+3+3) = 4.3 ≈ 5. Therefore, 5 days should be removed from the grapes' growth stage. It should take 5 days to grow and can be harvested on the 6th day. The following is the normal process:
    
<code>{1, 1, 2, 3 ,3}</code> --step 1-->  
 
<code>{1, 1, 2, 3 ,3}</code> --step 1-->  
Line 57: Line 57:  
:Please remember to discuss any major changes like this ''before'' implementing them.  I can't stress that enough.  It takes hours to keep the wikis maintained and consistent, and undoing changes made without discussion detracts from the time that could be spent updating pages.  Thank you for your work, [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 19:05, 20 April 2021 (UTC)
 
:Please remember to discuss any major changes like this ''before'' implementing them.  I can't stress that enough.  It takes hours to keep the wikis maintained and consistent, and undoing changes made without discussion detracts from the time that could be spent updating pages.  Thank you for your work, [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 19:05, 20 April 2021 (UTC)
   −
::Firstly, I don't think translating such a complex page could be simpler than translate only 30 keys in the dictionary table (about 50 English words totally). And I have translated the module to Chinese successfully. This page takes more than 300,000 bytes now, which too large to edit. When I edit the whole page in Chrome now, there's even a delay more than 1 second after I typing words. If necessary, I will help with this translation on other language wikis. Furthermore, updating the translation of other languages' pages could be much easier, see the second point.
+
::Firstly, I don't think translating such a complex page could be simpler than translate only 30 keys in the dictionary table (about 50 English words totally). And I have translated the module to Chinese successfully. This page takes more than 300,000 bytes now, which is too large to edit. When I edit the whole page in Chrome now, there's even a delay more than 1 second after I typing words. If necessary, I will help with this translation on other language wikis. Furthermore, updating the translation of other languages' pages could be much easier, see the second point.
   −
::Secondly, if there are more crops in the future, it's convenient to add new crop data from <tt>crops.xnb</tt> into the data table. The code should be updated when there are other types of speed-gro or something else that change the speed increase. But it's not complex, I can write the method in the document. Besides, this module also support returning only one single table when use the <tt>"mode"</tt> argument. It's simpler than updating the current page in this situation.
+
::Secondly, if there are more crops in the future, it's convenient to add new crop data from <samp>crops.xnb</samp> into the data table. The code should be updated when there are other types of speed-gro or something else that change the speed increase. But it's not complex, I can write the method in the document. Besides, this module also support returning only one single table when use the <samp>"mode"</samp> argument. It's simpler than updating the current page in this situation.
    
::Thirdly, I didn't implement any major change except for updating the [[:zh:作物生长日历]] and copying [[template:Addlanglinks]] to zh wiki, because there's no one else to talk with on zh wiki :( and these changes work well. You have undone these changes, but I don't think these operations will take you more than 15 minutes.
 
::Thirdly, I didn't implement any major change except for updating the [[:zh:作物生长日历]] and copying [[template:Addlanglinks]] to zh wiki, because there's no one else to talk with on zh wiki :( and these changes work well. You have undone these changes, but I don't think these operations will take you more than 15 minutes.
   −
::Fourthly, The module is still a draft. So I start a discussion here, and ''I haven't'' edited any major change on the English wiki.
+
::Fourthly, <s>the module is still a draft</s> (edited). So I start a discussion here, and ''I haven't'' edited any major change on the English wiki.
    
::Fifthly, the 25% Irrigated table of Unmilled Rice is incorrect as I said before. You can test this in the game.
 
::Fifthly, the 25% Irrigated table of Unmilled Rice is incorrect as I said before. You can test this in the game.
    
::At last, thanks for all your work to maintain and update this wiki. [[User:Horizon98|Horizon98]] ([[User talk:Horizon98|talk]]) 06:45, 21 April 2021 (UTC)
 
::At last, thanks for all your work to maintain and update this wiki. [[User:Horizon98|Horizon98]] ([[User talk:Horizon98|talk]]) 06:45, 21 April 2021 (UTC)
 +
 +
== Taro Root's season ==
 +
[[Taro Root]] grows in summer, but this page classifies this crop as [[Crop Growth Calendars#Other Crops|Other Crops]]. I think that it could be moved to [[Crop Growth Calendars#Summer Crops|Summer Crops]]. [[User:Horizon98|Horizon98]] ([[User talk:Horizon98|talk]]) 10:43, 22 April 2021 (UTC)
 +
 +
==Carrot Tables Row Height==
 +
The Agriculturist and Speed-Gro Comparison tables are displaying at different sizes.  This is because the Deluxe Speed-Gro & Hyper Speed-Gro for Agriculturist have a harvest every day except the first day; the images of the carrot stages and the carrot crop are different heights, causing the tables to be smaller for those 2 tables.  I would like to fix the row height for those tables at 48px to match the other tables but wanted to discuss here before making the changes.  I've uploaded a photo to show the difference between what is showing by default and the changes I would like to put in place.  Let me know if this formatting change is alright to make.  Thank you!!! [[User:KrobusFanClub|KrobusFanClub]] ([[User talk:KrobusFanClub|talk]]) 07:25, 7 May 2024 (UTC)
 +
:Hello again KFC! Your solution would work, but I thought it would be better to set the vertical alignment to "top", like the Hops' tables (and Ancient Fruit). While I was researching how to answer your query, I found it was easier to just make the change. So it should be all fixed, let me know if you have any other issues. And thank you for your kind words! [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 19:04, 7 May 2024 (UTC)
107,345

edits

Navigation menu