4,183
edits
Changes
no edit summary
I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe|BlaDe]] ([[User talk:BlaDe|talk]]) 08:33, 31 December 2021 (UTC)
I'm not sure on the best way to convey this on the page, so will leave this here and have another look in a few days.[[User:BlaDe|BlaDe]] ([[User talk:BlaDe|talk]]) 08:33, 31 December 2021 (UTC)
:Thanks, BlaDe, much appreciated! Please let me know if I can offer assistance. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 13:56, 31 December 2021 (UTC)
:Thanks, BlaDe, much appreciated! Please let me know if I can offer assistance. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 13:56, 31 December 2021 (UTC)
::I think the best thing to do is to rewrite the "rare fish not affected" section entirely. I'd remove the Scorpion Carp example but keep the Octopus one (the reason for keeping the Octopus one is because 1) it is not increased on the submarine (in fact, it decreases) and 2) to reinforce the fact that it is still affected on The Beach/Ginger Island West due to the global bite rate discussed in the first section). The Glacierfish example is accurate regardless because of the explicit Legendary Fish hook chances. [[User:User314159|User314159]] ([[User talk:User314159|talk]]) 15:06, 31 December 2021 (UTC)
:::I don't think the "fish affected by location" section is necessary. This is because all of the fish there fall into 3 categories: 1) legendary fish, 2) night market fish, and 3) mines fish, whose calculations depend directly in the getFish command in the game code. It is much easier to merge that section with the "specific calculations" section. I'd also expand the "global effects" section to make it clear that all fish are affected in some way, because with the way it is currently presented it is kind of easy to overlook it. [[User:User314159|User314159]] ([[User talk:User314159|talk]]) 15:31, 31 December 2021 (UTC)
::::I'm fine if we want to replace the "fish affected by location" with something else. I originally added that section because I wanted to list out exactly which fish were affected. When I came to this page all it said was that it "increases your chance to catch rare fish" without specifying which exact fish it affected. So I looked through the code to see which fish were affected, but then I noticed that there was some sort of global effect on catching fish. As best as I could tell it just made trash less likely to be caught, but I didn't attempt to figure out exact numbers. My preference is that we make sure every named fish that this directly affects is still named. BlaDe your spreadsheet is awesome, and Margotbean thanks for always looking to help on this wiki. Again, I haven't tried to figure out the math on how much chances already go up, so I'll leave it to the editors who have done that work on how that should be conveyed. [[User:Biochromatic|Biochromatic]] ([[User talk:Biochromatic|talk]]) 17:36, 31 December 2021 (UTC)
:::::I see, that makes sense. I agree that we should definitely keep the fish it directly affects still named. However, instead of sorting it by location, I think we should sort it by type (I described it above earlier). Sorting it by location is confusing and reads as if only those fish in those areas get affected, even though the global effect confirms that is not true. [[User:User314159|User314159]] ([[User talk:User314159|talk]]) 17:50, 31 December 2021 (UTC)