14
edits
Changes
→New TV display for extremely good luck?
:Because no luck buffs are active when the player sleeps, which is when the code executes. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 21:38, 15 November 2021 (UTC)
:Because no luck buffs are active when the player sleeps, which is when the code executes. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 21:38, 15 November 2021 (UTC)
::Fair point, <samp>player.dayupdate()</samp> calling <samp>Farmer::ClearBuffs</samp> happens before locations update in <samp>Game1::_newDayAfterFade</samp>. -- [[User:Charly|Charly]] ([[User talk:Charly|talk]]) 21:46, 15 November 2021 (UTC)
::Fair point, <samp>player.dayupdate()</samp> calling <samp>Farmer::ClearBuffs</samp> happens before locations update in <samp>Game1::_newDayAfterFade</samp>. -- [[User:Charly|Charly]] ([[User talk:Charly|talk]]) 21:46, 15 November 2021 (UTC)
::: As of version 1.5.4, I believe the luck buff from the Lucky Ring can affect animal drops. In <samp>Farmer::dayupdate</samp>, right after the <samp>ClearBuffs</samp> call, there's the following code snippet: <syntaxhighlight lang="C#">
if (leftRing.Value != null)
{
leftRing.Value.onDayUpdate(this, base.currentLocation);
}
if (rightRing.Value != null)
{
rightRing.Value.onDayUpdate(this, base.currentLocation);
}
</syntaxhighlight> The <samp>onDayUpdate</samp> method in <samp>Ring.cs</samp> calls the <samp>onEquip</samp> if the ring is item number 859, which corresponds to the Lucky Ring. So, the luck buff should be re-applied right after it's removed, and as far as I can tell the buff should now affect Rabbit's Feet and Duck Feathers. [[User:Mydan123|Mydan123]] ([[User talk:Mydan123|talk]]) 02:48, 2 August 2023 (UTC)
::::Interesting... I will try to make time to step through the code and verify whether or not this is true. Thank you for pointing this out!! [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 21:11, 2 August 2023 (UTC)
:::::Just so you don't think I've forgot about this, it appears to work that way in v1.5, but I want to hold off changing multiple pages on the wiki until I can verify if it works the same in v1.6. I spent 3 hours researching another issue today alone, so please be patient! And thanks again for reporting this!! [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 00:07, 9 August 2023 (UTC)
== I feel there should more detail on how luck is calculated ==
== I feel there should more detail on how luck is calculated ==
:The page doesn't say the chance of a true neutral event is 0, but the fortune teller does say "it's rare". You are free to write up an explanation of how luck is calculated, though I would put the first draft here on the talk page or in your user space. Be sure to cite that code reference by class and method. If you can find the code reference for food buffs, please feel free to add it to the page. And please remember to sign your comments with four tildes <nowiki>~~~~</nowiki>. Thanks, [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:22, 21 May 2022 (UTC)
:The page doesn't say the chance of a true neutral event is 0, but the fortune teller does say "it's rare". You are free to write up an explanation of how luck is calculated, though I would put the first draft here on the talk page or in your user space. Be sure to cite that code reference by class and method. If you can find the code reference for food buffs, please feel free to add it to the page. And please remember to sign your comments with four tildes <nowiki>~~~~</nowiki>. Thanks, [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:22, 21 May 2022 (UTC)
== Naming convention for "Luck Effects" headings ==
== How to structure the Luck page for easier understanding ==
I recently made a "bold" [https://stardewvalleywiki.com/mediawiki/index.php?title=Luck&type=revision&diff=147376&oldid=147375 edit] to [[Luck]] in order to rearrange some sections for clarity -- it was reverted due to duplicate section headers. The original, unmodified section headers are as follows:
I recently made a "bold" [https://stardewvalleywiki.com/mediawiki/index.php?title=Luck&type=revision&diff=147376&oldid=147375 edit] to [[Luck]] in order to rearrange some sections for clarity -- it was reverted due to duplicate section headers. The original, unmodified section headers are as follows:
::(followed of course by the other sections like Special Charm.) Thoughts? [[User:Cooperka|Cooperka]] ([[User talk:Cooperka|talk]]) 21:32, 11 April 2023 (UTC)
::(followed of course by the other sections like Special Charm.) Thoughts? [[User:Cooperka|Cooperka]] ([[User talk:Cooperka|talk]]) 21:32, 11 April 2023 (UTC)
:::Honestly, to me that sounds really convoluted. The page evolved to what it is because people didn't understand the differences between what the two types of luck affected, and they seemed quite happy with the current format. I'm open to input from other readers. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 21:42, 11 April 2023 (UTC)
::::Will wait for more input from others! In the meantime I'll apply the other minor improvements to the page. [[User:Cooperka|Cooperka]] ([[User talk:Cooperka|talk]]) 22:39, 11 April 2023 (UTC)
== New TV display for extremely good luck? ==
While playing, I've encountered this TV screen as when watching the Fortune Teller (note the extra starry background): [[File:20240415114726 1.jpg]]
Is this display shown when the daily luck is especially good?
Also, want to tell that the text is identical to the regular best luck text: "The spirits are very happy today! They will do their best to shower everyone with good fortune." [[User:BidBux|BidBux]] ([[User talk:BidBux|talk]]) 13:24, 15 April 2024 (UTC)
:Okay, it appears that there are two new TV screens for the Fortune Teller in the cases of best and worst possible daily luck, or so I've been told. So far I've only encountered the best luck screen. Someone should update the table with those new sprites. ([[User:BidBux|BidBux]] ([[User talk:BidBux|talk]]) 05:11, 16 April 2024 (UTC))
::Alright, I have discovered the worst luck screen too now. Here's how it looks: [[File:Fortune Teller worst luck screenshot.jpg]]
::Would really be great if someone could turn these into proper GIFs and put them into the page. ([[User:BidBux|BidBux]] ([[User talk:BidBux|talk]]) 11:01, 18 April 2024 (UTC))