260
edits
Changes
Jump to navigation
Jump to search
Line 6:
Line 6: − + + + + + + + + + + + + + + + + + + + + + +
copy discussion that led to changes to this page
From day one on this wiki there were always problems with results produced by the templates, until NebulousMaestress finally fixed them about 5 months ago. What is it about v1.5 that has introduced something that worked completely in v1.4? [[User:Giles|Giles]] ([[User talk:Giles|talk]]) 05:12, 30 April 2021 (UTC)
From day one on this wiki there were always problems with results produced by the templates, until NebulousMaestress finally fixed them about 5 months ago. What is it about v1.5 that has introduced something that worked completely in v1.4? [[User:Giles|Giles]] ([[User talk:Giles|talk]]) 05:12, 30 April 2021 (UTC)
:See [[Template talk:Artisan]]. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 04:41, 1 May 2021 (UTC)
:See <strike>[[Template talk:Artisan]]</strike> below. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 04:41, 1 May 2021 (UTC)
==Wrong prices==
(Note: I copied this discussion over from Template talk:Artisan, since Template:Artisan has been marked for deletion. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 22:08, 5 May 2021 (UTC))
I noticed on some pickles that the pricing is off by 1 gold (e.g. Garlic and Ginger). For example Garlic regular is 60g. Pickled Garlic is 2 x 60 + 50 = 170. Still good. But then the artisan: multiplier 170 x 1.4 = 238. But the formula and thus infobox spits out '''237g''' Weird! [[User:Dubesor|Dubesor]] ([[User talk:Dubesor|talk]]) 03:49, 28 April 2021 (UTC)
:This problem has plagued the wiki since its inception! On the old wiki, a user rewrote [[:Template:infobox]] to supposedly fix the problem... I guess it didn't work for all cases. The underlying problem is that the wiki can't replicate C# code, and the equation for calculating artisan sell prices is a bit convoluted in the game. You can look at the [https://stardewcommunitywiki.com/Template_talk:Artisan old talk page] to see the equation at that time. Anyway, it's a long-standing problem with no simple fix. :( [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:00, 28 April 2021 (UTC)
::The old talk page claims that [* 14 / 10.0] is a workaround for [* 1.4], but that's only used here for wine, not pickles. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 19:54, 28 April 2021 (UTC)
:::None of that got implemented, afaik. It's just background on the problem. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 20:54, 28 April 2021 (UTC)
::::I realize now this template is not the problem. It returns a correct value when called. The problem appears to be in [[:Template:Qualityprice]]. If I call that template directly, I get an incorrect value. So it looks like it's not necessary to decipher all the complicated stuff [[:Template:Infobox]] is doing. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 21:27, 28 April 2021 (UTC)
::::Update: I have a version of that template that works with the few values I've given it (it returns 238 with the above inputs, for example). Not a very comprehensive test, really. Should I push it out to the world and see if it breaks anything? (See [[User:Zendowolf/Sandbox/Qualityprice]]) [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 21:50, 28 April 2021 (UTC)
:::::I'm sorry, I thought I read that you didn't do comprehensive testing, but wanted to know if you should push an update that could affect thousands of pages in 12 languages. I must be dreaming or something. 🤔[[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 02:43, 29 April 2021 (UTC)
::::::No, I was not suggesting that we propagate an untested change to all 12 languages.
::::::Here's the thing, I do not have the resources to do what I would consider a comprehensive test: set up a test server and copy everything over, before making the change there and testing it. Can you set up a test server?
::::::The alternative, copying all the relevant templates down to a sandbox area and editing them all to point to each other rather than the real templates, is too messy to contemplate. You don't pay me enough to do that.
::::::So I took a step back. It's a really simple change. The chances of it causing a problem seem extremely small. The possibility of recovery if there is a problem seem very high: Wikimedia is designed to revert changes quickly and easily. So we make the changes to the English-language wiki, at a time when we can monitor it. Make sure everything is as expected and there are no unforeseen side-effects. If it breaks something, we revert it. Back to the drawing board. If it works as expected, maybe we give it a little time to reveal any surprises. Then in due course, we propagate it to the other languages.
::::::A less cautious person probably would've already made the changes. It probably would be fine.[[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 07:50, 29 April 2021 (UTC)
:::::::The last time I made a change to the equation, I fixed half the items and broke the other half. It was a wash. This is why I require comprehensive testing, more than just 4 items. You don't need to set up a test server to do comprehensive testing. There are two methods:
::::::#There is a link at the bottom of every template page that says "Preview page with this template" so you can preview changes before committing them.
::::::#The old-fashioned way is to add "noinclude" tags at the bottom of the template, then add all items affected, then preview the change and check them all for accuracy.
:::::::In this way, we can be sure we're not just shifting the "off by one" problem from existing items to other items that are now correct. [[User:Margotbean|margotbean]] ([[User talk:Margotbean|talk]]) 18:47, 29 April 2021 (UTC)
::::::::I did a fair bit of regression testing using the method you described. The only differences I found were cases where the immediate problem had been fixed. Then I committed the changes because to abandon them at that point would invalidate the tests. [[User:Zendowolf|Zendowolf]] ([[User talk:Zendowolf|talk]]) 21:50, 29 April 2021 (UTC)